Skip to content

Require React 18 #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Require React 18 #1710

wants to merge 2 commits into from

Conversation

alexeyr-ci
Copy link
Collaborator

@alexeyr-ci alexeyr-ci commented Mar 9, 2025 •
edited by alexeyr-ci2
Loading

Summary

Remove React 16/17 support in order to:

  • Simplify code
  • Optimize bundle size

This is a breaking change; do not merge until we start working on 16.0.0!

Pull Request checklist

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

This change is Reviewable

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 9, 2025 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch alexeyr/require-react-18

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alexeyr-ci alexeyr-ci force-pushed the alexeyr/require-react-18 branch 2 times, most recently from 639df23 to 375d3a9 Compare March 9, 2025 09:23
@alexeyr-ci alexeyr-ci mentioned this pull request Mar 9, 2025
Closed
3 tasks
@alexeyr-ci alexeyr-ci force-pushed the alexeyr/require-react-18 branch 6 times, most recently from 0d28231 to 3c5e74d Compare March 9, 2025 12:25
@alexeyr-ci alexeyr-ci force-pushed the alexeyr/format-typescript branch from de23424 to 403d323 Compare March 10, 2025 09:27
@alexeyr-ci alexeyr-ci force-pushed the alexeyr/require-react-18 branch from 3c5e74d to fb0ac06 Compare March 10, 2025 09:40
Base automatically changed from alexeyr/format-typescript to master March 12, 2025 11:34
@justin808
Copy link
Member

@alexeyr-ci2 What's the point of this PR?

@alexeyr-ci alexeyr-ci force-pushed the alexeyr/require-react-18 branch from fb0ac06 to 42819f1 Compare September 15, 2025 11:32
@alexeyr-ci alexeyr-ci force-pushed the alexeyr/require-react-18 branch from 42819f1 to 9101887 Compare September 15, 2025 12:21
@alexeyr-ci2
Copy link
Collaborator

@justin808 Added summary.

@alexeyr-ci2 alexeyr-ci2 mentioned this pull request Sep 15, 2025
Draft
4 tasks
@justin808
Copy link
Member

How big is this;

  • Optimize bundle size

Is this really worth changing now?

@alexeyr-ci2
Copy link
Collaborator

@justin808 It's mostly about making our code simpler, and simplifying maintenance for the future. Obviously not right now while HiChee isn't on React 18 yet. It will be more convenient to measure bundle size change once Popmenu is on ROR 15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexeyr-ci @justin808 @alexeyr-ci2 @alexeyr